Skip to content

simplify code using optional chaining in ZoneWizardLaunchZone view#5619

Merged
yadvr merged 2 commits intoapache:mainfrom
Damans227:issue_4956
Dec 30, 2021
Merged

simplify code using optional chaining in ZoneWizardLaunchZone view#5619
yadvr merged 2 commits intoapache:mainfrom
Damans227:issue_4956

Conversation

@Damans227
Copy link
Copy Markdown
Collaborator

Description

This PR is related to issue: ui: Simplify code #4956

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Damans227
Copy link
Copy Markdown
Collaborator Author

@davidjumani PTAL when you get a chance. Thanks!

Comment thread ui/src/views/infra/zone/ZoneWizardLaunchZone.vue Outdated
@Damans227 Damans227 requested a review from utchoang October 25, 2021 13:53
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-833)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5619 (SL-JID-837)

@yadvr yadvr added this to the 4.17.0.0 milestone Dec 30, 2021
@yadvr yadvr merged commit 49b2dfc into apache:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants